Merge pull request 'develop' (#46) from develop into main

Reviewed-on: #46

.gitignore

@@ -2,5 +2,3 @@
 # Notepad++ backups #
 *.bak
 
-
-.vscode/

custom_sounds.hpp

@@ -1,8 +0,0 @@
-
-// EXAMPLE
-// class uncon_alarm
-// {
-//     name = "uncon_alarm";
-//     sound[] = {"AJ_CBRN_V2\sounds\AJ_warning_1.ogg", 0.9, 1, 5}; //directory, volume, pitch, range
-//     titles[]={};
-// };

defines/VehicleFlags.hpp

@@ -84,159 +84,30 @@ class VehicleFlags {
 			actionID = "flag_simpleshape";
 			actionTitle = "Simple Shapes";
 
-			class Blue {
-				actionID = "flags_simpleshape_blue";
-				actionTitle = "Blue";
-
-				class BlueCircle {
-					actionID = "flag_simpleshape_bluecircle";
-					actionTitle = "Blue Circle";
-					texture = "textures\simple_shape\flag_simpleshape_bluecircle_co.paa";
-				};
-				class BlueOctagon {
-					actionID = "flag_simpleshape_blueoctagon";
-					actionTitle = "Blue Octagon";
-					texture = "textures\simple_shape\flag_simpleshape_blueoctagon_co.paa";
-				};
-				class BluePentagon {
-					actionID = "flag_simpleshape_bluepentagon";
-					actionTitle = "Blue Pentagon";
-					texture = "textures\simple_shape\flag_simpleshape_bluepentagon_co.paa";
-				};
-				class BlueSquare {
-					actionID = "flag_simpleshape_bluesquare";
-					actionTitle = "Blue Square";
-					texture = "textures\simple_shape\flag_simpleshape_bluesquare_co.paa";
-				};
-				class BlueTriangle {
-					actionID = "flag_simpleshape_bluetriangle";
-					actionTitle = "Blue Triangle";
-					texture = "textures\simple_shape\flag_simpleshape_bluetriangle_co.paa";
-				};
+			class GreenOctagon {
+				actionID = "flag_simpleshape_greenoctagon";
+				actionTitle = "Green Octagon";
+				texture = "textures\simple_shape\flag_simpleshape_greenoctagon_co.paa";
 			};
-
-			class Green {
-				actionID = "flags_simpleshape_green";
-				actionTitle = "Green";
-
-				class GreenCircle {
-					actionID = "flag_simpleshape_greencircle";
-					actionTitle = "Green Circle";
-					texture = "textures\simple_shape\flag_simpleshape_greencircle_co.paa";
-				};
-				class GreenOctagon {
-					actionID = "flag_simpleshape_greenoctagon";
-					actionTitle = "Green Octagon";
-					texture = "textures\simple_shape\flag_simpleshape_greenoctagon_co.paa";
-				};
-				class GreenPentagon {
-					actionID = "flag_simpleshape_greenpentagon";
-					actionTitle = "Green Pentagon";
-					texture = "textures\simple_shape\flag_simpleshape_greenpentagon_co.paa";
-				};
-				class GreenSquare {
-					actionID = "flag_simpleshape_greensquare";
-					actionTitle = "Green Square";
-					texture = "textures\simple_shape\flag_simpleshape_greensquare_co.paa";
-				};
-				class GreenTriangle {
-					actionID = "flag_simpleshape_greentriangle";
-					actionTitle = "Green Triangle";
-					texture = "textures\simple_shape\flag_simpleshape_greentriangle_co.paa";
-				};
+			class BlueCircle {
+				actionID = "flag_simpleshape_bluecircle";
+				actionTitle = "Blue Circle";
+				texture = "textures\simple_shape\flag_simpleshape_bluecircle_co.paa";
 			};
-
-			class Orange {
-				actionID = "flags_simpleshape_orange";
-				actionTitle = "Orange";
-
-				class OrangeCircle {
-					actionID = "flag_simpleshape_orangecircle";
-					actionTitle = "Orange Circle";
-					texture = "textures\simple_shape\flag_simpleshape_orangecircle_co.paa";
-				};
-				class OrangeOctagon {
-					actionID = "flag_simpleshape_orangeoctagon";
-					actionTitle = "Orange Octagon";
-					texture = "textures\simple_shape\flag_simpleshape_orangeoctagon_co.paa";
-				};
-				class OrangePentagon {
-					actionID = "flag_simpleshape_orangepentagon";
-					actionTitle = "Orange Pentagon";
-					texture = "textures\simple_shape\flag_simpleshape_orangepentagon_co.paa";
-				};
-				class OrangeSquare {
-					actionID = "flag_simpleshape_orangesquare";
-					actionTitle = "Orange Square";
-					texture = "textures\simple_shape\flag_simpleshape_orangesquare_co.paa";
-				};
-				class OrangeTriangle {
-					actionID = "flag_simpleshape_orangetriangle";
-					actionTitle = "Orange Triangle";
-					texture = "textures\simple_shape\flag_simpleshape_orangetriangle_co.paa";
-				};
+			class OrangeSquare {
+				actionID = "flag_simpleshape_orangesquare";
+				actionTitle = "Orange Square";
+				texture = "textures\simple_shape\flag_simpleshape_orangesquare_co.paa";
 			};
-
-			class Pink {
-				actionID = "flags_simpleshape_pink";
-				actionTitle = "Pink";
-
-				class PinkCircle {
-					actionID = "flag_simpleshape_pinkcircle";
-					actionTitle = "Pink Circle";
-					texture = "textures\simple_shape\flag_simpleshape_pinkcircle_co.paa";
-				};
-				class PinkOctagon {
-					actionID = "flag_simpleshape_pinkoctagon";
-					actionTitle = "Pink Octagon";
-					texture = "textures\simple_shape\flag_simpleshape_pinkoctagon_co.paa";
-				};
-				class PinkPentagon {
-					actionID = "flag_simpleshape_pinkpentagon";
-					actionTitle = "Pink Pentagon";
-					texture = "textures\simple_shape\flag_simpleshape_pinkpentagon_co.paa";
-				};
-				class PinkSquare {
-					actionID = "flag_simpleshape_pinksquare";
-					actionTitle = "Pink Square";
-					texture = "textures\simple_shape\flag_simpleshape_pinksquare_co.paa";
-				};
-				class PinkTriangle {
-					actionID = "flag_simpleshape_pinktriangle";
-					actionTitle = "Pink Triangle";
-					texture = "textures\simple_shape\flag_simpleshape_pinktriangle_co.paa";
-				};
+			class PinkTriangle {
+				actionID = "flag_simpleshape_pinktriangle";
+				actionTitle = "Pink Triangle";
+				texture = "textures\simple_shape\flag_simpleshape_pinktriangle_co.paa";
 			};
-
-			class Red {
-				actionID = "flags_simpleshape_red";
-				actionTitle = "Red";
-				
-				class RedCircle {
-					actionID = "flag_simpleshape_redcircle";
-					actionTitle = "Red Circle";
-					texture = "textures\simple_shape\flag_simpleshape_redcircle_co.paa";
-				};
-				class RedOctagon {
-					actionID = "flag_simpleshape_redoctagon";
-					actionTitle = "Red Octagon";
-					texture = "textures\simple_shape\flag_simpleshape_redoctagon_co.paa";
-				};
-				class RedPentagon {
-					actionID = "flag_simpleshape_redpentagon";
-					actionTitle = "Red Pentagon";
-					texture = "textures\simple_shape\flag_simpleshape_redpentagon_co.paa";
-				};
-				class RedSquare {
-					actionID = "flag_simpleshape_redsquare";
-					actionTitle = "Red Square";
-					texture = "textures\simple_shape\flag_simpleshape_redsquare_co.paa";
-				};
-				class RedTriangle {
-					actionID = "flag_simpleshape_redtriangle";
-					actionTitle = "Red Triangle";
-					texture = "textures\simple_shape\flag_simpleshape_redtriangle_co.paa";
-				};
+			class RedPentagon {
+				actionID = "flag_simpleshape_redpentagon";
+				actionTitle = "Red Pentagon";
+				texture = "textures\simple_shape\flag_simpleshape_redpentagon_co.paa";
 			};
 		};
 

description.ext

@@ -96,10 +96,6 @@ class CfgFunctions {
 	#include "custom_scripts.hpp"
 };
 
-class CfgSounds {
-	#include "custom_sounds.hpp"
-};
-
 class CfgLeaflets {
 	#include "custom_leaflets.hpp"
 };

framework/CfgFunctions.hpp

@@ -120,7 +120,6 @@ class DOUBLES(PREFIX,performance) {
 		class addServerStatsPFH {};
 		class calculateServerStats {};
 		class addEmptyGroupCleanupPFH {};
-		class addDeadUnitCleanupPFH {};
 	};
 };
 
@@ -175,8 +174,6 @@ class DOUBLES(PREFIX,vehicleFlags) {
 		class addFlagActions {};
 		class draw3D {};
 		class getActionsFlagCategories {};
-		class compileFlagAction {};
-		class compileFlagCategoryAction {};
 		class getVehicleFlagsCfg {};
 		class isClassExcluded {};
 	};

framework/init/functions/fn_initServer.sqf

@@ -21,23 +21,6 @@ _curators = allMissionObjects "ModuleCurator_F";
 	_x removeCuratorAddons ["A3_Modules_F_Curator_Lightning"]; 
 } foreach _curators;
 
-// add dead unit time marking for custom garbage cleanup function
-addMissionEventHandler ["EntityKilled", {
-	params ["_unit", "_killer", "_instigator", "_useEffects"];
-
-	if not (_unit isKindOf "CAManBase") exitWith {};
-
-	if not (isInRemainsCollector _unit)  exitWith {};
-
-	// format["%1 from group %2 died at %3", _unit, group _unit, [datetime] call BIS_fnc_timeToString] remoteExec ["systemChat"];
-	_unit setVariable["milsim_death_time", time];
-	// _unit addEventHandler ["Deleted", {
-	// 	params ["_entity"];
-	// 	isGC = _entity getVariable["milsim_garbage_collected", false];
-	// 	format["%1 from was deleted by custom gc: %2", _entity, str isGC ] remoteExec ["systemChat"];
-	// }];
-}];
-
 // declare init complete to other modules
 missionNamespace setVariable [QGVARMAIN(complete), true, true];
 

framework/performance/functions/fn_addCBASettings.sqf

@@ -1,9 +1,5 @@
 #include "..\script_component.hpp"
 
-//---------------------
-//	Garbage Collection
-//---------------------
-
 [
 	QGVAR(emptyGroupCleanup_enable),
 	"CHECKBOX",
@@ -26,28 +22,6 @@
 	}
 ] call CBA_fnc_addSetting;
 
-[
-	QGVAR(deadUnitCleanup_enable),
-	"CHECKBOX",
-	"Dead Unit Cleanup Enabled",
-	[QUOTE(SETTINGS_GROUP_NAME), QUOTE(COMPONENT_BEAUTIFIED)],
-	true,
-	true,
-	{
-		params ["_value"];
-		[
-			QGVAR(deadUnitCleanup_enable),
-			_value
-		] call EFUNC(common,logSettingChanged);
-
-		if (!isNull (missionNamespace getVariable [QGVAR(deadUnitCleanupPFH), locationNull])) then {
-			deleteLocation GVAR(deadUnitCleanupPFH);
-		};
-
-		call FUNC(addDeadUnitCleanupPFH);
-	}
-] call CBA_fnc_addSetting;
-
 //---------------------
 //	Server CPS
 //---------------------

framework/performance/functions/fn_addDeadUnitCleanupPFH.sqf

@@ -1,55 +0,0 @@
-#include "..\script_component.hpp"
-
-[
-	LEVEL_INFO,
-	QUOTE(COMPONENT),
-	"Initializing dead unit deletion PFH",
-	[]
-] call EFUNC(common,log);
-
-GVAR(deadUnitCleanupPFH) = [
-	{ 
-		_maxTime = getMissionConfigValue ["corpseRemovalMaxTime", 300] * 1.5;
-		_maxDead = getMissionConfigValue ["corpseLimit", 80];
-
-		// _dead = allDead select { (_x isKindOf "CAManBase") and ( ( (time - (_x getVariable ["milsim_death_time", time] ) ) > (_maxTime * 1.5) ) ) };
-		// _dead = _dead apply { [ (time - (_x getVariable ["milsim_death_time", time] ) ), _x ] };
-
-		_dead = [];
-		{
-			if not (_x isKindOf "CAManBase") then { continue };
-			if not (isInRemainsCollector _x) then { continue };
-			_dead pushBack [time - (_x getVariable ["milsim_death_time", time] ), _x];
-		} forEach allDead;
-
-		_dead sort false;
-		_toDelete = 0 max ( (count _dead ) - _maxDead );
-		_dead = _dead select [0, _toDelete];
-		{
-			_unit = _x#1;
-			// _unit setVariable ["milsim_garbage_collected", true];
-			deleteVehicle (_unit);
-		} foreach _dead;
-	},
-	180,
-	[],
-	{ // on creation
-		[
-			LEVEL_INFO,
-			QUOTE(COMPONENT),
-			"dead unit deletion PFH loaded",
-			[]
-		] call EFUNC(common,log);
-	},
-	{ // on deletion
-		[
-			LEVEL_INFO,
-			QUOTE(COMPONENT),
-			"dead unit deletion PFH unloaded",
-			[]
-		] call EFUNC(common,log);
-	},
-	{ (missionNamespace getVariable [QGVAR(deadUnitCleanup_enable), false]) },
-	{ false },
-	[]
-] call CBA_fnc_createPerFrameHandlerObject;

framework/resupply/functions/fn_createBox.sqf

@@ -162,7 +162,7 @@ if (isNil "_items") exitWith {
 [_box,1] call ace_cargo_fnc_setSize;
 
 // ignore weight restrictions for carry/drag
-_box setVariable ["ace_dragging_ignoreWeightCarry", true, true];
+_box setVariable ["ace_ignoreWeightCarry", true, true];
 
 // Return the box
 _box;

framework/vehicleFlags/functions/fn_compileFlagAction.sqf

@@ -1,38 +0,0 @@
-params ["_target", "_player", "_params", "_flagOptionCfg"];
-_params params ["_rootActionID", "_flagCategoryActionID", "_flagSubclassesCfgs"];
-
-private _flagOptionID = getText(_flagOptionCfg >> "actionID");
-private _flagOptionTitle = getText(_flagOptionCfg >> "actionTitle");
-private _flagOptionTexture = getText(_flagOptionCfg >> "texture");
-
-// if the texture doesn't exist at the config path, skip this flag option
-if (not (fileExists _flagOptionTexture)) then {
-	diag_log format ["WARN: Flag option texture not found: %1", _flagOptionTexture];
-	continue
-};
-
-// diag_log format ["NewFlagOption: %1 %2", _flagOptionID, _flagOptionData];
-
-private _newFlagOption = [
-	
-	_rootActionID + "_" + _flagCategoryActionID + "_" + _flagOptionID, // id 
-	_flagOptionTitle, // displayed title
-	_flagOptionTexture, // flag icon
-	{
-		params ["_target", "_player", "_params"];
-		_params params ["_flagOptionTexture"];
-		_target forceFlagTexture _flagOptionTexture;
-	}, // statement
-	{
-		params ["_target", "_player", "_params"];
-		alive _target;
-		// true;
-	}, // condition
-	nil, // child code
-	[_flagOptionTexture], // params
-	nil, // position
-	4, // distance
-	[false, false, false, false, false] // other params
-] call ace_interact_menu_fnc_createAction;
-
-_newFlagOption;

framework/vehicleFlags/functions/fn_compileFlagCategoryAction.sqf

@@ -1,52 +0,0 @@
-// diag_log format ["NewFlagCategory: %1 %2", _flagCategory, _flagOptions];
-
-params ["_rootActionID", "_flagCategoryCfg"];
-private _flagCategoryActionID = getText(_flagCategoryCfg >> "actionID");
-private _flagCategoryTitle = getText(_flagCategoryCfg >> "actionTitle");
-
-private _flagSubclassesCfgs = _flagCategoryCfg call BIS_fnc_returnChildren;
-
-private _flagCategoryAction = [
-	_rootActionID + "_" + _flagCategoryActionID, // id
-	_flagCategoryTitle, // displayed title
-	getText((_flagSubclassesCfgs#0) >> "texture"), // flag icon for category - use first flag option
-	{true}, // statement
-	{
-		params ["_target", "_player", "_params"];
-		alive _target;
-		// true;
-	}, // condition
-	{
-		// generate child code under category
-		// this is the level where actual flag options will be displayed
-		params ["_target", "_player", "_params"];
-		// these params are passed from the parent action
-		_params params ["_rootActionID", "_flagCategoryActionID", "_flagSubclassesCfgs"];
-
-		private _individualFlagActions = [];
-		{ // forEach _flagSubclassesCfgs; // we'll generate flag options for each category
-			private _flagOptionCfg = _x;
-
-			// generate flag option for this flag option
-			private _newFlagOption = [
-				_target,
-				_player,
-				_params,
-				_flagOptionCfg
-			] call FUNC(compileFlagAction);
-
-			// add flag option to category subactions
-			_individualFlagActions pushBack [_newFlagOption, [], _target];
-		} forEach _flagSubclassesCfgs;
-
-		// return the generated flag options to the category as child actions
-		_individualFlagActions;
-	}, // child code
-	[_rootActionID, _flagCategoryActionID, _flagSubclassesCfgs], // params
-	nil, // position
-	4, // distance
-	[false, false, false, false, false], // other params
-	nil // modifier function code
-] call ace_interact_menu_fnc_createAction;
-
-_flagCategoryAction;

framework/vehicleFlags/functions/fn_getActionsFlagCategories.sqf

@@ -11,18 +11,80 @@ params ["_rootActionID", "_flagCategoryCfgs"];
 private _allCategoryActions = [];
 
 {
-	_flagCategoryActions = [];
-	if (configName _x == "SimpleShapes") then {
+	// diag_log format ["NewFlagCategory: %1 %2", _flagCategory, _flagOptions];
+
+	private _flagCategoryCfg = _x;
+	private _flagCategoryActionID = getText(_flagCategoryCfg >> "actionID");
+	private _flagCategoryTitle = getText(_flagCategoryCfg >> "actionTitle");
+
+	private _flagSubclassesCfgs = _flagCategoryCfg call BIS_fnc_returnChildren;
+
+	private _flagCategoryAction = [
+		_rootActionID + "_" + _flagCategoryActionID, // id
+		_flagCategoryTitle, // displayed title
+		getText((_flagSubclassesCfgs#0) >> "texture"), // flag icon for category - use first flag option
+		{true}, // statement
 		{
-			_flagCategoryActions pushBack ([_rootActionID, _x] call FUNC(compileFlagCategoryAction));
-		} forEach (_x call BIS_fnc_returnChildren);
-	} else {
-		_flagCategoryActions pushBack (_x call FUNC(compileFlagCategoryAction));
-	};
+			params ["_target", "_player", "_params"];
+			alive _target;
+			// true;
+		}, // condition
+		{
+			// generate child code under category
+			// this is the level where actual flag options will be displayed
+			params ["_target", "_player", "_params"];
+			_params params ["_rootActionID", "_flagCategoryActionID", "_flagSubclassesCfgs"];
+
+			private _individualFlagActions = [];
+			{ // forEach _flagSubclassesCfgs;
+				private _flagOptionCfg = _x;
+				private _flagOptionID = getText(_flagOptionCfg >> "actionID");
+				private _flagOptionTitle = getText(_flagOptionCfg >> "actionTitle");
+				private _flagOptionTexture = getText(_flagOptionCfg >> "texture");
+
+				// if the texture doesn't exist at the config path, skip this flag option
+				if (not (fileExists _flagOptionTexture)) then {continue};
+
+				// diag_log format ["NewFlagOption: %1 %2", _flagOptionID, _flagOptionData];
+
+				private _newFlagOption = [
+					
+					_rootActionID + "_" + _flagCategoryActionID + "_" + _flagOptionID, // id 
+					_flagOptionTitle, // displayed title
+					_flagOptionTexture, // flag icon
+					{
+						params ["_target", "_player", "_params"];
+						_params params ["_flagOptionTexture"];
+						_target forceFlagTexture _flagOptionTexture;
+					}, // statement
+					{
+						params ["_target", "_player", "_params"];
+						alive _target;
+						// true;
+					}, // condition
+					nil, // child code
+					[_flagOptionTexture], // params
+					nil, // position
+					4, // distance
+					[false, false, false, false, false] // other params
+				] call ace_interact_menu_fnc_createAction;
+
+				// add flag option to category subactions
+				_individualFlagActions pushBack [_newFlagOption, [], _target];
+			} forEach _flagSubclassesCfgs;
+
+			// return the generated flag options to the category as child actions
+			_individualFlagActions;
+		}, // child code
+		[_rootActionID, _flagCategoryActionID, _flagSubclassesCfgs], // params
+		nil, // position
+		4, // distance
+		[false, false, false, false, false], // other params
+		nil // modifier function code
+	] call ace_interact_menu_fnc_createAction;
+
 	// add category to all category actions array
-	{
-		_allCategoryActions pushBack [_x, [], _target];
-	} forEach _flagCategoryActions;
+	_allCategoryActions pushBack [_flagCategoryAction, [], _target];
 } forEach _flagCategoryCfgs;
 
 _allCategoryActions;