optimize remainsCollector #39

New Issue

hizumi · 2024-03-19T21:20:29-05:00

hizumi commented

2024-03-19 21:20:29 -05:00

after indeterminate amount of time, built in remains collect fails to remove corpses regardless of locality

add debugging to fn_addEmptyGroupCleanupPFH as script does run, but fails to remove some empty groups
add custom remains collector PFH, with validation via isInRemainsCollector, to delete at 2 * getMissionConfigValue "corpseRemovalMaxTime" interval
~~[ ] or alternatively, use built in groupEmpty / MPKilled event handlers to bind to the individual units~~

after indeterminate amount of time, built in remains collect fails to remove corpses regardless of locality - [x] add debugging to fn_addEmptyGroupCleanupPFH as script does run, but fails to remove some empty groups - [x] add custom remains collector PFH, with validation via `isInRemainsCollector`, to delete at 2 * `getMissionConfigValue "corpseRemovalMaxTime"` interval - ~~[ ] or alternatively, use built in groupEmpty / MPKilled event handlers to bind to the individual units~~

hizumi added the Kind/Enhancement

labels 2024-03-19 21:20:29 -05:00

hizumi self-assigned this 2024-03-19 21:41:42 -05:00

hizumi commented

2024-04-21 19:45:04 -05:00

step 1 active in v4.1.2

hizumi commented

2024-05-23 21:31:50 -05:00

step 2 chosen. code to be tested in v4.2.0 at 0f8783ffa9

step 2 chosen. code to be tested in v4.2.0 at https://gitea.iceberg-gaming.com/17th-Ranger-Battalion-ORG/MissionTemplate/commit/0f8783ffa9cdbb47cf661d924cfde5fca36b2fb3

hizumi commented

2024-05-25 23:54:24 -05:00

debug discoveries:

certain objects which are not men... are in fact still men (looking at you blackwasp)
certain objects spawn invisible objects which are still classified as men (looking at you blackwasp)
certain inventory objects which spawn as men are not automatically added to remainsCollector (looking at you blackwasp)
sometimes vehicles and emplacements are registered as isKindOf CAManBase, but not in the remainsCollector when they should be (wtf igla_aa_pod and van_01_transport)
sometimes spawned ai are attached to the first available curator slot despite them not being the originator of the spawn
sometimes bodies are transfered to server ownership with a live player identified prefix bis_o2_ despite the player still occupying a body

revision todos:

add owner, decay time, and type to EntityDeleted EH (for when it is deleted via console, zeus, or by remainsCollector)
find a way to detect if object deleted is via zeus interface (possibly CuratorObjectDeleted, deletion may be logged twice) (true)
log in PFH when a dead body gathered for deletion is not owned by server or headless client ~~and skip deletion~~

debug discoveries: - certain objects which are not men... are in fact still men (looking at you `blackwasp`) - certain objects spawn invisible objects which are still classified as men (looking at you `blackwasp`) - certain inventory objects which spawn as men are not automatically added to `remainsCollector` (looking at you `blackwasp`) - sometimes vehicles and emplacements are registered as `isKindOf CAManBase`, but not in the `remainsCollector` when they should be (wtf `igla_aa_pod` and `van_01_transport`) - sometimes spawned ai are attached to the first available curator slot despite them not being the originator of the spawn - sometimes bodies are transfered to server ownership with a live player identified prefix `bis_o2_` despite the player still occupying a body revision todos: - [x] add owner, decay time, and type to `EntityDeleted` EH (for when it is deleted via `console`, `zeus`, or by `remainsCollector`) - [x] find a way to detect if object deleted is via zeus interface (possibly `CuratorObjectDeleted`, deletion may be logged twice) (***true***) - [x] log in PFH when a dead body gathered for deletion is not owned by server or headless client ~~and skip deletion~~

hizumi commented

2024-06-16 21:30:41 -05:00

committed to develop

hizumi commented

2024-06-19 20:56:55 -05:00

completed via 7c6130891a

completed via 7c6130891a161a137da1c6afbb4fb39ace51dc04

hizumi closed this issue

2024-06-19 20:56:55 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: 17th-Ranger-Battalion-ORG/MissionTemplate#39