17th-Ranger-Battalion-ORG/milsim-site-v4
8
1
Fork 0
Code Issues 38 Pull Requests 1 Actions 3 Packages Projects 1 Releases 14 Wiki Activity

Tweaked LOA API RBAC to allow full command group access
All checks were successful
Continuous Integration / Update Development (push) Successful in 2m48s
Details
Continuous Deployment / Update Deployment (push) Successful in 2m32s
Details

Browse Source
This commit is contained in:
ajdj100
2025-12-22 21:36:10 -05:00
parent a52f5cd31a
commit 3848eb939a
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
api/src/routes/loa.ts
View File

@@ -26,7 +26,7 @@ router.post("/", async (req: Request, res: Response) => {
}); });
//admin posts LOA //admin posts LOA
router.post("/admin", [requireRole("17th Administrator")], async (req: Request, res: Response) => { router.post("/admin", [requireRole(['17th Administrator', '17th HQ', '17th Command'])], async (req: Request, res: Response) => {
let LOARequest = req.body as LOARequest; let LOARequest = req.body as LOARequest;
LOARequest.created_by = req.user.id; LOARequest.created_by = req.user.id;
LOARequest.filed_date = new Date(); LOARequest.filed_date = new Date();
@@ -67,7 +67,7 @@ router.get("/history", async (req: Request, res: Response) => {
} }
}) })
router.get('/all', [requireRole("17th Administrator")], async (req: Request, res: Response) => { router.get('/all', [requireRole(['17th Administrator', '17th HQ', '17th Command'])], async (req: Request, res: Response) => {
try { try {
const page = Number(req.query.page) || undefined; const page = Number(req.query.page) || undefined;
const pageSize = Number(req.query.pageSize) || undefined; const pageSize = Number(req.query.pageSize) || undefined;
@@ -107,7 +107,7 @@ router.post('/cancel/:id', async (req: Request, res: Response) => {
}) })
//TODO: enforce admin only //TODO: enforce admin only
router.post('/adminCancel/:id', [requireRole("17th Administrator")], async (req: Request, res: Response) => { router.post('/adminCancel/:id', [requireRole(['17th Administrator', '17th HQ', '17th Command'])], async (req: Request, res: Response) => {
let closer = req.user.id; let closer = req.user.id;
try { try {
await closeLOA(Number(req.params.id), closer); await closeLOA(Number(req.params.id), closer);
@@ -119,7 +119,7 @@ router.post('/adminCancel/:id', [requireRole("17th Administrator")], async (req:
}) })
// TODO: Enforce admin only // TODO: Enforce admin only
router.post('/extend/:id', [requireRole("17th Administrator")], async (req: Request, res: Response) => { router.post('/extend/:id', [requireRole(['17th Administrator', '17th HQ', '17th Command'])], async (req: Request, res: Response) => {
const to: Date = req.body.to; const to: Date = req.body.to;
if (!to) { if (!to) {