Upgraded handling of duplicate member roles Close #56

2025-12-18 22:38:36 -05:00
parent 80786f996f
commit 8903baef52
2 changed files with 7 additions and 2 deletions
--- a/api/src/routes/roles.ts
+++ b/api/src/routes/roles.ts
@@ -16,10 +16,16 @@ ur.post('/', [requireMemberState(MemberState.Member), requireRole("17th Administ
    try {
        const body = req.body;

-        assignUserGroup(body.member_id, body.role_id);
+        await assignUserGroup(body.member_id, body.role_id);

        res.sendStatus(201);
    } catch (err) {
+        if (err?.code === 'ER_DUP_ENTRY') {
+            return res.status(400).json({
+                error: 'Member already has this role',
+            });
+        }
+
        console.error('Insert failed:', err);
        res.status(500).json({ error: 'Failed to add to group' });
    }