17th-Ranger-Battalion-ORG/milsim-site-v4
8
1
Fork 0
Code Issues 22 Pull Requests 1 Actions 2 Packages Projects Releases Wiki Activity

Refactored rank change logic

Browse Source
This commit is contained in:
ajdj100
2025-10-13 14:34:12 -04:00
parent b268ee46e1
commit 8c2872cd54
3 changed files with 32 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
api/routes/ranks.js
View File

@@ -1,20 +1,15 @@
const express = require('express');
const r = express.Router();
const ur = express.Router();
const { getAllRanks, insertMemberRank } = require('../services/rankService')
const pool = require('../db');
//insert a new latest rank for a user
ur.post('/', async (req, res) => {
ur.post('/', async (req, res) => {3
try {
const change = req.body?.change;
console.log(change);
const sql = `INSERT INTO members_ranks (member_id, rank_id, event_date) VALUES (?, ?, ?);`;
const params = [change.member_id, change.rank_id, change.event_date]
await pool.query(sql, params);
await insertMemberRank(change);
res.sendStatus(201);
} catch (err) {
@@ -26,8 +21,9 @@ ur.post('/', async (req, res) => {
//get all ranks
r.get('/', async (req, res) => {
try {
const result = await pool.query('SELECT id, name, short_name, sort_id FROM ranks;');
res.json(result);
const ranks = await getAllRanks();
console.log(ranks);
res.json(ranks);
} catch (err) {
console.error(err);
res.status(500).json({ error: 'Internal server error' });