Implemented admin assign unit UI
All checks were successful
Pull Request CI / Merge Check (pull_request) Successful in 3m55s

This commit is contained in:
2026-03-02 20:16:28 -05:00
parent 54dcb9d389
commit a988545dda
7 changed files with 278 additions and 5 deletions

View File

@@ -103,7 +103,7 @@ import { roles, memberRoles } from './routes/roles';
import { courseRouter, eventRouter } from './routes/course'; import { courseRouter, eventRouter } from './routes/course';
import { calendarRouter } from './routes/calendar'; import { calendarRouter } from './routes/calendar';
import { docsRouter } from './routes/docs'; import { docsRouter } from './routes/docs';
import { units } from './routes/units'; import { memberUnits, units } from './routes/units';
app.use('/application', applicationRouter); app.use('/application', applicationRouter);
app.use('/ranks', ranks); app.use('/ranks', ranks);
@@ -118,6 +118,7 @@ app.use('/course', courseRouter)
app.use('/courseEvent', eventRouter) app.use('/courseEvent', eventRouter)
app.use('/calendar', calendarRouter) app.use('/calendar', calendarRouter)
app.use('/units', units) app.use('/units', units)
app.use('/memberUnits', memberUnits);
app.use('/docs', docsRouter) app.use('/docs', docsRouter)
app.use('/', authRouter) app.use('/', authRouter)

View File

@@ -1,10 +1,16 @@
import express = require('express'); import express = require('express');
const unitsRouter = express.Router(); const unitsRouter = express.Router();
const memberUnitsRouter = express.Router();
import { Request, Response } from 'express';
import pool from '../db'; import pool from '../db';
import { requireLogin } from '../middleware/auth'; import { requireLogin, requireMemberState, requireRole } from '../middleware/auth';
import { logger } from '../services/logging/logger'; import { logger } from '../services/logging/logger';
import { Unit } from '@app/shared/types/units'; import { Unit } from '@app/shared/types/units';
import { MemberState } from '@app/shared/types/member';
import { assignNewUnit } from '../services/db/unitService';
import { audit } from '../services/logging/auditLog';
unitsRouter.use(requireLogin); unitsRouter.use(requireLogin);
@@ -26,4 +32,38 @@ unitsRouter.get('/', async (req, res) => {
} }
}); });
memberUnitsRouter.post('/admin', [requireMemberState(MemberState.Member), requireRole("17th Administrator")], async (req: Request, res: Response) => {
const memberId = Number(req.query.memberId);
const unitId = Number(req.query.unitId);
const reason = req.query.reason as string;
try {
if (!memberId || !unitId) {
return res.status(400).json({ error: 'memberId and unitId query parameters are required' });
}
await assignNewUnit(memberId, unitId, req.user.id, req.user.id, reason);
logger.info('app', 'Member force assigned unit', {
member: memberId,
unit: unitId,
caller: req.user.id,
});
audit.member('update_unit', { actorId: req.user.id, targetId: memberId }, { unit: unitId, reason: reason });
res.sendStatus(200);
} catch (error) {
logger.error('app', 'Failed to force assign unit', {
member: memberId,
unit: unitId,
caller: req.user.id,
error: error instanceof Error ? error.message : String(error),
stack: error instanceof Error ? error.stack : undefined,
})
res.sendStatus(500);
}
});
export const units = unitsRouter; export const units = unitsRouter;
export const memberUnits = memberUnitsRouter;

View File

@@ -10,4 +10,13 @@ export async function cancelLatestUnit(userID: number, con: mariadb.Pool | maria
} catch (error) { } catch (error) {
throw error; throw error;
} }
}
export async function assignNewUnit(memberID: number, unitID: number, authorizedID: number, creatorID: number, reason: string) {
let sql = `CALL sp_update_member_unit(?, ?, ?, ?, ?, NOW())`;
const result = await pool.query(sql, [memberID, unitID, authorizedID, creatorID, reason]);
if (!result || result.affectedRows === 0) {
throw new Error('Record was not updated');
}
} }

View File

@@ -32,8 +32,8 @@ class AuditLogger {
logger.error('audit', `AUDIT_FAILURE: Failed to log ${actionType}`, { error: err }); logger.error('audit', `AUDIT_FAILURE: Failed to log ${actionType}`, { error: err });
} }
} }
member(action: 'update_rank' | 'suspension_added' | 'suspension_removed' | 'discharged', context: AuditContext, data: any = {}) { member(action: 'update_rank'| 'update_unit' | 'suspension_added' | 'suspension_removed' | 'discharged', context: AuditContext, data: any = {}) {
return this.record('member', action, context, data); return this.record('member', action, context, data);
} }

View File

@@ -12,4 +12,15 @@ export async function getUnits(): Promise<Unit[]> {
throw new Error("Failed to fetch units"); throw new Error("Failed to fetch units");
} }
return response.json(); return response.json();
}
export async function adminAssignUnit(member: number, unit: number, reason: string) {
const response = await fetch(`${addr}/memberUnits/admin?memberId=${member}&unitId=${unit}&reason=${encodeURIComponent(reason)}`, {
method: 'POST',
credentials: 'include'
});
if (!response.ok) {
throw new Error("Failed to assign unit");
}
return;
} }

View File

@@ -0,0 +1,194 @@
<script setup lang="ts">
import { computed, ref, watch } from 'vue'
import { adminAssignUnit, getUnits } from '@/api/units'
import { Button } from '@/components/ui/button'
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from '@/components/ui/dialog'
import { Field, FieldError, FieldLabel } from '@/components/ui/field'
import { Input } from '@/components/ui/input'
import {
Select,
SelectContent,
SelectItem,
SelectTrigger,
SelectValue,
} from '@/components/ui/select'
import MemberCard from './MemberCard.vue'
import type { Member } from '@shared/types/member'
import type { Unit } from '@shared/types/units'
const props = defineProps<{
open: boolean
member: Member | null
}>()
const emit = defineEmits<{
'update:open': [value: boolean]
transferred: [value: { memberId: number; unitId: number; reason: string }]
}>()
const units = ref<Unit[]>([])
const loadingUnits = ref(false)
const submitting = ref(false)
const formError = ref('')
const selectedUnitId = ref('')
const selectedReason = ref('transfer_request')
const customReason = ref('')
const reasonOptions = [
{ label: 'Transfer Request', value: 'transfer_request' },
{ label: 'Leadership Vote', value: 'leadership_vote' },
{ label: 'Step Down', value: 'step_down' },
{ label: 'Custom', value: 'custom' },
]
const resolvedReason = computed(() => {
if (selectedReason.value === 'custom') {
return customReason.value.trim()
}
return selectedReason.value
})
const canSubmit = computed(() => {
return !!props.member && !!selectedUnitId.value && !!resolvedReason.value
})
function resetForm() {
selectedUnitId.value = ''
selectedReason.value = 'transfer_request'
customReason.value = ''
formError.value = ''
}
async function loadUnits() {
loadingUnits.value = true
formError.value = ''
try {
units.value = await getUnits()
} catch {
formError.value = 'Failed to load units. Please try again.'
} finally {
loadingUnits.value = false
}
}
watch(
() => props.open,
(isOpen) => {
if (isOpen) {
resetForm()
loadUnits()
}
},
)
async function onSubmit() {
if (!props.member) {
return
}
if (!selectedUnitId.value) {
formError.value = 'Please select a target unit.'
return
}
if (!resolvedReason.value) {
formError.value = 'Please select a reason or enter a custom reason.'
return
}
submitting.value = true
formError.value = ''
try {
const unitId = Number(selectedUnitId.value)
await adminAssignUnit(props.member.member_id, unitId, resolvedReason.value)
emit('transferred', {
memberId: props.member.member_id,
unitId,
reason: resolvedReason.value,
})
emit('update:open', false)
} catch {
formError.value = 'Failed to transfer member. Please try again.'
} finally {
submitting.value = false
}
}
</script>
<template>
<Dialog :open="open" @update:open="emit('update:open', $event)">
<DialogContent class="sm:max-w-[425px]">
<DialogHeader>
<DialogTitle>Transfer Member</DialogTitle>
<DialogDescription>
Select a new unit assignment for
<MemberCard v-if="member" :member-id="member.member_id" />
</DialogDescription>
</DialogHeader>
<form id="transferForm" @submit.prevent="onSubmit" class="space-y-4 py-2">
<Field>
<FieldLabel>Target Unit</FieldLabel>
<Select v-model="selectedUnitId" :disabled="loadingUnits || submitting">
<SelectTrigger>
<SelectValue placeholder="Select unit" />
</SelectTrigger>
<SelectContent>
<SelectItem v-for="unit in units" :key="unit.id" :value="String(unit.id)">
{{ unit.name }}
</SelectItem>
</SelectContent>
</Select>
</Field>
<Field>
<FieldLabel>Reason</FieldLabel>
<Select v-model="selectedReason" :disabled="submitting">
<SelectTrigger>
<SelectValue placeholder="Select reason" />
</SelectTrigger>
<SelectContent>
<SelectItem
v-for="reason in reasonOptions"
:key="reason.value"
:value="reason.value"
>
{{ reason.label }}
</SelectItem>
</SelectContent>
</Select>
</Field>
<Field v-if="selectedReason === 'custom'">
<FieldLabel>Custom Reason</FieldLabel>
<Input
v-model="customReason"
:disabled="submitting"
placeholder="Enter custom transfer reason"
/>
</Field>
<FieldError v-if="formError" :errors="[formError]" />
</form>
<DialogFooter class="gap-2">
<Button variant="ghost" @click="emit('update:open', false)">
Cancel
</Button>
<Button type="submit" form="transferForm" :disabled="!canSubmit || loadingUnits || submitting">
{{ submitting ? 'Transferring...' : 'Transfer Member' }}
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
</template>

View File

@@ -34,6 +34,7 @@
import MemberCard from "@/components/members/MemberCard.vue"; import MemberCard from "@/components/members/MemberCard.vue";
import { useMemberDirectory } from "@/stores/memberDirectory"; import { useMemberDirectory } from "@/stores/memberDirectory";
import { Discharge } from "@shared/schemas/dischargeSchema"; import { Discharge } from "@shared/schemas/dischargeSchema";
import TransferMember from "@/components/members/TransferMember.vue";
// --- State --- // --- State ---
const router = useRouter(); const router = useRouter();
@@ -141,13 +142,19 @@
//discharge form logic //discharge form logic
const isDischargeOpen = ref(false) const isDischargeOpen = ref(false)
const targetMember = ref(null) const isTransferOpen = ref(false)
const targetMember = ref<Member | null>(null)
function openDischargeModal(member: Member) { function openDischargeModal(member: Member) {
targetMember.value = member targetMember.value = member
isDischargeOpen.value = true isDischargeOpen.value = true
} }
function openTransferModal(member: Member) {
targetMember.value = member
isTransferOpen.value = true
}
async function onSuspend(member: Member) { async function onSuspend(member: Member) {
await suspendMember(member.member_id); await suspendMember(member.member_id);
await fetchMembers(); await fetchMembers();
@@ -166,12 +173,19 @@
fetchMembers(); fetchMembers();
memberCache.invalidateMember(value.data.userID); memberCache.invalidateMember(value.data.userID);
} }
function handleTransferSuccess(value: { memberId: number; unitId: number; reason: string }) {
fetchMembers();
memberCache.invalidateMember(value.memberId);
}
</script> </script>
<template> <template>
<div> <div>
<DischargeMember v-model:open="isDischargeOpen" :member="targetMember" @discharged="handleDischargeSuccess"> <DischargeMember v-model:open="isDischargeOpen" :member="targetMember" @discharged="handleDischargeSuccess">
</DischargeMember> </DischargeMember>
<TransferMember v-model:open="isTransferOpen" :member="targetMember" @transferred="handleTransferSuccess">
</TransferMember>
<div class="mx-auto max-w-7xl w-full py-10 px-4"> <div class="mx-auto max-w-7xl w-full py-10 px-4">
<div class="flex flex-col gap-2"> <div class="flex flex-col gap-2">
<div class="flex flex-col md:flex-row md:items-center justify-between gap-4"> <div class="flex flex-col md:flex-row md:items-center justify-between gap-4">
@@ -270,6 +284,10 @@
<!-- <DropdownMenuItem @click="navigateToMember(member.member_id)"> <!-- <DropdownMenuItem @click="navigateToMember(member.member_id)">
View Profile View Profile
</DropdownMenuItem> --> </DropdownMenuItem> -->
<DropdownMenuItem v-if="member.member_state !== MemberState.Discharged"
@click="openTransferModal(member)">
Transfer Member
</DropdownMenuItem>
<DropdownMenuItem v-if="member.member_state !== MemberState.Discharged" <DropdownMenuItem v-if="member.member_state !== MemberState.Discharged"
@click="openDischargeModal(member)" @click="openDischargeModal(member)"
class="text-destructive focus:bg-destructive focus:text-destructive-foreground font-medium"> class="text-destructive focus:bg-destructive focus:text-destructive-foreground font-medium">