Merge pull request 'Allow recruiters to see admin pages' (#206 ) from Recruiter-Permission-Fix into main

Reviewed-on: #206
Merge branch 'main' into Recruiter-Permission-Fix
2026-03-21 18:42:29 -05:00 · 2026-03-21 18:42:18 -05:00 · 2026-03-21 19:44:57 -04:00 · 2026-03-21 18:41:06 -05:00 · 2026-03-12 22:23:28 -04:00
2 changed files with 3 additions and 3 deletions
--- a/api/src/routes/applications.ts
+++ b/api/src/routes/applications.ts
@@ -396,11 +396,11 @@ VALUES(?, ?, ?, 1);`
          INNER JOIN members AS member ON member.id = app.poster_id
        WHERE app.id = ?; `;
    const comment = await conn.query(getSQL, [result.insertId])
-    audit.record('application', 'comment_added', { actorId: user.id, targetId: appID }, { commentId: result.insertId });
+    audit.record('application', 'comment_added', { actorId: user.id, targetId: appID }, { commentId: Number(result.insertId) });
    logger.info('app', "Admin application comment posted", {
      application: appID,
      poster: user.id,
-      comment: result.insertId,
+      comment: Number(result.insertId),
    })

    res.status(201).json(comment[0]);
--- a/ui/src/router/index.ts
+++ b/ui/src/router/index.ts
@@ -33,7 +33,7 @@ const router = createRouter({
    // ADMIN / STAFF ROUTES
    {
      path: '/administration',
-      meta: { requiresAuth: true, memberOnly: true, roles: ['17th Administrator', '17th HQ', '17th Command'] },
+      meta: { requiresAuth: true, memberOnly: true, roles: ['17th Administrator', '17th HQ', '17th Command', '17th Recruiter'] },
      children: [
        { path: 'applications', component: () => import('@/pages/ManageApplications.vue') },
        { path: 'applications/:id', component: () => import('@/pages/ManageApplications.vue') },
Author	SHA1	Message	Date
Ajdj100	b4ff7d4686	Merge pull request 'Allow recruiters to see admin pages' (#206 ) from Recruiter-Permission-Fix into main All checks were successful Testing Site CD / Update Development (push) Successful in 4m15s Details Reviewed-on: #206	2026-03-21 18:42:29 -05:00
Ajdj100	171e3b3137	Merge branch 'main' into Recruiter-Permission-Fix All checks were successful Pull Request CI / Merge Check (pull_request) Successful in 3m53s Details	2026-03-21 18:42:18 -05:00
ajdj100	dd2ac19e4a	Allow recruiters to see admin pages All checks were successful Pull Request CI / Merge Check (pull_request) Successful in 4m0s Details	2026-03-21 19:44:57 -04:00
Ajdj100	18ba9b576c	Merge pull request 'Fixed error on posting admin comment' (#205 ) from Application-Admin-Comment-Fix into main Some checks failed Testing Site CD / Update Development (push) Has been cancelled Details Reviewed-on: #205	2026-03-21 18:41:06 -05:00
ajdj100	6c85677e1b	Fixed error on posting admin comment All checks were successful Pull Request CI / Merge Check (pull_request) Successful in 4m10s Details	2026-03-12 22:23:28 -04:00