17th-Ranger-Battalion-ORG/milsim-site-v4
8
1
Fork 0
Code Issues 38 Pull Requests 1 Actions 3 Packages Projects 1 Releases 14 Wiki Activity

Application Form Tweaks #54

New Issue
Open
opened 2025-12-03 20:05:56 -06:00 by EagleTrooper · 5 comments
EagleTrooper commented 2025-12-03 20:05:56 -06:00
Owner
Copy Link

Front End Applicant Side

Things to Review (High Priority)

  • No Error "Required" for Checking the Code of Conduct when clicking submit. Apparently Required but not required not required. - "Required" Text is not clear (needs to be Colored / moved up next to question.
  • When logged in as my own discord account, I posted a "Comment on my own Application and it put OCEAN as the poster.. Guess ID number 1.

Application_Comment_Posted_Wrong_Author.gif

  • Header scrolls when i reach "have you ever served in the military"

Header_Pushed_Military_Question.gif

  • When Member is guest I we dont see Previous applications
  • When a member is "denied" they cant re-apply it only says denied.
  • When a member is "banned or retired" it shows them an application Progress which starts at "Create your account" with Submit / Review / Acceptance all Clickable.
  • The Data Key for rules is splled incorrectly \"aknowledgeRules\":true

Things to Review (Medium Priority)

  • Validation of Steam URL Format?
  • 2 Regex Provide
    • With Named Groups : (?<CUSTOMPROFILE>https?\:\/\/steamcommunity.com\/id\/[A-Za-z_0-9]+)|(?<CUSTOMURL>\/id\/[A-Za-z_0-9]+)|(?<PROFILE>https?\:\/\/steamcommunity.com\/profiles\/[0-9]+)|(?<STEAMID2>STEAM_[10]:[10]:[0-9]+)|(?<STEAMID3>\[U:[10]:[0-9]+\])
    • Without Named Groups: (https?\:\/\/steamcommunity.com\/id\/[A-Za-z_0-9]+)|(\/id\/[A-Za-z_0-9]+)|(https?\:\/\/steamcommunity.com\/profiles\/[0-9]+)|(STEAM_[10]:[10]:[0-9]+)|(\[U:[10]:[0-9]+\])

Things to Review (Low Priority)

  • Time zone Dropdown / Filter / Search instead of Freeform
    image.png

Front End Processor Side

  • Should be made clear that application comments are public and not internal only
## Front End Applicant Side ### Things to Review (High Priority) - [x] No Error "Required" for Checking the Code of Conduct when clicking submit. Apparently Required but not required not required. - "Required" Text is not clear (needs to be Colored / moved up next to question. - [x] When logged in as my own discord account, I posted a "Comment on my own Application and it put OCEAN as the poster.. Guess ID number 1. > ![Application_Comment_Posted_Wrong_Author.gif](/attachments/39e9de1d-a930-441c-b80b-9fefc5303450) - [x] Header scrolls when i reach "have you ever served in the military" > ![Header_Pushed_Military_Question.gif](/attachments/e68438c4-ae4a-4ef3-a064-0cd7d2d45b13) - [x] When Member is guest I we dont see Previous applications - [x] When a member is "denied" they cant re-apply it only says denied. - [x] When a member is "banned or retired" it shows them an application Progress which starts at "Create your account" with Submit / Review / Acceptance all Clickable. - [x] The Data Key for rules is splled incorrectly `\"aknowledgeRules\":true` - [ ] ### Things to Review (Medium Priority) - [x] Validation of Steam URL Format? - 2 Regex Provide - With Named Groups : `(?<CUSTOMPROFILE>https?\:\/\/steamcommunity.com\/id\/[A-Za-z_0-9]+)|(?<CUSTOMURL>\/id\/[A-Za-z_0-9]+)|(?<PROFILE>https?\:\/\/steamcommunity.com\/profiles\/[0-9]+)|(?<STEAMID2>STEAM_[10]:[10]:[0-9]+)|(?<STEAMID3>\[U:[10]:[0-9]+\])` - Without Named Groups: `(https?\:\/\/steamcommunity.com\/id\/[A-Za-z_0-9]+)|(\/id\/[A-Za-z_0-9]+)|(https?\:\/\/steamcommunity.com\/profiles\/[0-9]+)|(STEAM_[10]:[10]:[0-9]+)|(\[U:[10]:[0-9]+\])` - [ ] ### Things to Review (Low Priority) - [ ] Time zone Dropdown / Filter / Search instead of Freeform <img width="236" alt="image.png" src="attachments/6e0b6aac-e190-4499-be10-9be66587ecc2"> ## Front End Processor Side - [x] Should be made clear that application comments are public and not internal only - [ ]
image.png
5.9 KiB
Header_Pushed_Military_Question.gif
1.1 MiB
Application_Comment_Posted_Wrong_Author.gif
66 KiB
Ajdj100 added reference #54-Application-tweaks 2025-12-08 14:36:53 -06:00
Ajdj100 commented 2025-12-08 15:15:23 -06:00
Member
Copy Link

Header scroll is wontfix here, that seems to be a bigger application wide issue that only manifests here because its the only page that's tall enough to provoke it

Header scroll is wontfix here, that seems to be a bigger application wide issue that only manifests here because its the only page that's tall enough to provoke it
Ajdj100 commented 2025-12-08 21:31:21 -06:00
Member
Copy Link

Banned behavior will be handled in #61

Banned behavior will be handled in #61
Ajdj100 commented 2025-12-09 11:59:42 -06:00
Member
Copy Link

Wont do timezone dropdown for now, that can be made a post 1.0 upgrade.

Wont do timezone dropdown for now, that can be made a post 1.0 upgrade.
EagleTrooper commented 2025-12-13 15:51:41 -06:00
Author
Owner
Copy Link

  • Birthday also has no validation
    image.png

  • Code of Conduct doesn't load (Issue with brining in bookstack docs.iceberg-gaming.com
    image.png

- [ ] Birthday also has no validation <img width="334" alt="image.png" src="attachments/b9522680-7d18-4e46-a983-155337a1f9d9"> - [x] Code of Conduct doesn't load (Issue with brining in bookstack docs.iceberg-gaming.com <img width="503" alt="image.png" src="attachments/e12be015-91ac-42ca-a564-45f2c1493f71">
image.png
14 KiB
image.png
8.8 KiB
EagleTrooper added the Member Application label 2025-12-14 13:57:19 -06:00
EagleTrooper commented 2025-12-14 14:53:21 -06:00
Author
Owner
Copy Link
  • When submitting an application you cannot submit any letters in the "How long have you played arma3" for except for the letter e.. WHen you do enter the letter e it takes it as a valid entry but the application won't submit.

Once submitted then it fully breaks the application for
Application_Process_Hours.gif

- [x] When submitting an application you cannot submit any letters in the "How long have you played arma3" for except for the letter `e`.. WHen you do enter the letter `e` it takes it as a valid entry but the application won't submit. Once submitted then it fully breaks the application for ![Application_Process_Hours.gif](/attachments/8c17f149-d5c7-4c19-a556-b3d0dfdf2bb1)
Application_Process_Hours.gif
866 KiB
Sign in to join this conversation.
#54-Application-tweaks
Branches Tags
Labels
Clear labels
Calendar
Attaches Issue to Calendar Feature
 Database Changes
Leave of Absence (LOA)
Attaches issue to LOA
 Member Application
Related to the Application Process for Members joining.
 Top Hitlist
Training Reports
Attaches issue to Training Report Feature
Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Member Application
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Ajdj100 EagleTrooper Iceberg_Gaming_Team IndigoFox KenJeongUn Randy hizumi slothdotpy
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 17th-Ranger-Battalion-ORG/milsim-site-v4#54
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?