Merge pull request 'Adjust Draw3D Triage Deceased Color to Dark Gray' (#5) from feature/triagestatus-draw3d into main

Reviewed-on: https://17th-gs.iceberg-gaming.com:5443/hizumi/MissionTemplate/pulls/5

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project badly attempts [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [3.1.3] - 2024-01-10
+
+
+### Changed
+- Merge triage-status-draw3d to fix draw overlay for medics
+
 ## [3.1.2] - 2024-01-04
 
 ### Added

functions/CfgFunctions.hpp

@@ -32,7 +32,7 @@ class milsim
 		class bindEventHandlers { postInit = 1; };
 		class bindVehicleActions { postInit = 1; };
 		class addClientStatsPFH {};
-		class addMedicalOverlayPFH { postInit = 1; }; // nees refactor
+		class addMedicalOverlayPFH { postInit = 1; };
 		class calculateClientStats {};
 		class initVehicleFlags { postInit = 1; };
 		class bindEmptyGroupGarbageCleanup { postInit = 1; };

functions/client/fn_addClientStatsPFH.sqf

@@ -8,7 +8,7 @@ _cpsPFH = [
 	},
 	"milsim_client_cps_interval" call CBA_settings_fnc_get,
 	[],
-	{ diag_log text format ["[MILSIM] (client) PFH loaded with interval %1 seconds", "milsim_client_cps_interval" call CBA_settings_fnc_get ], },
+	{ diag_log text format ["[MILSIM] (client) PFH loaded with interval %1 seconds", "milsim_client_cps_interval" call CBA_settings_fnc_get ] },
 	{ diag_log text format ["[MILSIM] (client) PFH unloaded"] },
 	{ "milsim_client_cps_enable" call CBA_settings_fnc_get },
 	{ false },

functions/client/fn_addMedicalOverlayPFH.sqf

@@ -1,14 +1,28 @@
-// Enable/Disable the script
+/*
+
+milsim_fnc_addMedicalOverlayPFH
+
+Author: IndigoFox
+
+Description:
+    Affects players with medical permissions. Will see a 3D colored dot over nearby (5-10m)
+	unconscious players who are not in a vehicle
+	which indicates their current ACE Triage Card status.
+	Designed to increase efficiency of CCPs.
+
+*/
+
+// Force setting if CBA doesn't work?
 if (isNil "milsim_client_medState3D_enabled") then {
 	milsim_client_medState3D_enabled = true;
 };
+if (isNil "milsim_client_medState3D_drawRange") then {
+	milsim_client_medState3D_drawRange = 10;
+};
 
 // List of units to draw icons for
 milsim_client_medState3D_drawTargets = []; 
 
-// Range to draw icons for
-milsim_client_medState3D_drawRange = 10;
-
 // ACE Triage colors, for consistency across UIs and functions
 // #define TRIAGE_COLOR_NONE      0.5, 0.5, 0.5, 0.1
 // #define TRIAGE_COLOR_MINIMAL   0, 0.5, 0, 0.9
@@ -21,59 +35,65 @@ milsim_client_medState3D_colors = [
 	[0, 0.5, 0, 0.9], // TRIAGE_COLOR_MINIMAL
 	[1, 0.84, 0, 0.9], // TRIAGE_COLOR_DELAYED
 	[1, 0, 0, 0.9], // TRIAGE_COLOR_IMMEDIATE
-	[0, 0, 0, 0.9], // TRIAGE_COLOR_DECEASED
+	[0.15, 0.15, 0.15, 0.9], // TRIAGE_COLOR_DECEASED
 	[0.5, 0.5, 0.5, 0] // TRIAGE_COLOR_NONE
 ];
 
 // Per-frame handler to draw icons
-milsim_client_medState3D_pfh = [
+// cleanup
+if (!isNil "milsim_client_medState3D_pfh") then {
+	[milsim_client_medState3D_pfh] call CBA_fnc_removePerFrameHandler;
+};
+// add pfh
+milsim_client_medState3D_pfh =	[{
+	// if disabled, skip processing
+	if (!milsim_client_medState3D_enabled) exitWith {false};
+	// if no targets, skip processing
+	if (count milsim_client_medState3D_drawTargets == 0) exitWith {false};
+	if !([player] call ace_medical_treatment_fnc_isMedic) exitWith {false};
 	{
-		// if disabled, skip processing
-		if (!milsim_client_medState3D_enabled) exitWith {};
+		// distance within 10 meters
+		if (player distance _x > milsim_client_medState3D_drawRange) then {continue};
+		// check unit not null, not conscious, and not in a vehicle
+		if (
+			!(_x getVariable ["ACE_isUnconscious", false]) ||
+			!isNull (objectParent _x)
+		) then {continue};
 
-		// if no targets, skip processing
-		if (count milsim_client_medState3D_drawTargets == 0) exitWith {};
+		// color based on triage level
+		private _triageLevel = _x getVariable ["ace_medical_triageLevel", -1];
+		if (_triageLevel == -1) then {continue};
+		private _color = milsim_client_medState3D_colors select (
+			(_x getVariable ["ace_medical_triageLevel", -1]) -1
+		);
+		// draw position, slightly above the prone unit
+		private _drawPos = (visiblePosition _x) vectorAdd [0, 0, 0.5];
+		// draw icon
+		drawIcon3D [
+			"\A3\ui_f\data\map\markers\military\dot_CA.paa", // icon texture
+			_color, // color
+			_drawPos, // position AGL
+			1, // width
+			1, // height
+			0 // angle
+			// further params optional, omitted
+		];
+	} forEach milsim_client_medState3D_drawTargets;
+}, 0, []] call CBA_fnc_addPerFrameHandler;
 
-		if !([player] call ace_medical_treatment_fnc_isMedic) exitWith {};
-
-		{
-			// distance within 10 meters
-			if (player distance _x > milsim_client_medState3D_drawRange) then {continue};
-			// check unit not null, not conscious, and not in a vehicle
-			if (
-				isNull _x ||
-				!(_x getVariable ["ACE_isUnconscious", false]) ||
-				!isNull (objectParent _x)
-			) then {continue};
-			
-			// color based on triage level
-			private _color = milsim_client_medState3D_colors select ((_x getVariable ["ace_medical_triageLevel", -1]) -1);
-			// draw position, slightly above the prone unit
-			private _drawPos = (visiblePosition _x) vectorAdd [0, 0, 0.5];
-			// draw icon
-			drawIcon3D [
-				"\A3\ui_f\data\map\markers\military\dot_CA.paa", // icon texture
-				_color, // color
-				_drawPos, // position AGL
-				1, // width
-				1, // height
-				0 // angle
-				// further params optional, omitted
-			];
-		} forEach milsim_client_medState3D_drawTargets;
-	},
-	0,
-	[]
-] call CBA_fnc_addPerFrameHandler;
-
-[
-	"Man",
-	"InitPost",
-	{
-		params ["_unit"];
-		milsim_client_medState3D_drawTargets pushBack _unit;
-	},
-	true,
-	[],
-	true
-] call CBA_fnc_addClassEventHandler;
+// subroutine to gather nearest 50 units every 5 seconds and store in milsim_client_medState3D_drawTargets
+// cleanup
+if (!isNil "milsim_client_medState3D_drawTargetsPfh") then {
+	[milsim_client_medState3D_drawTargetsPfh] call CBA_fnc_removePerFrameHandler;
+};
+// add pfh
+milsim_client_medState3D_drawTargetsPfh = [{
+	milsim_client_medState3D_drawTargets = (
+		(allUnits + allDeadMen) select {
+			_x isKindOf "CAManBase" && 
+			player distance _x < 50 &&
+			!isNull _x &&
+			player isNotEqualTo _x
+		}
+	);
+}, 5, false] call CBA_fnc_addPerFrameHandler;

functions/settings/fn_addCBASettings.sqf

@@ -109,13 +109,22 @@
 //---------------------
 
 [
-	"milsim_client_medState3D_enabled",
-	"CHECKBOX",
-	["Enable 3D Triage Card State", "Draws a colored dot over units within 10m indicating current ACE Triage State"],
-	"Medical",
-	true
+	"milsim_client_medState3D_enabled", // variable
+	"CHECKBOX", // type
+	["Enable 3D Triage Card State", "Draws a colored dot over units within 10m indicating current ACE Triage State"], // title
+	["17th Battalion", "Medical"], // category
+	true // default value
 ] call CBA_fnc_addSetting;
 
+[
+	"milsim_client_medState3D_drawRange", // variable
+	"LIST", // type
+	["Range To Draw Icons", "Determines range at which dots are visible"], // title
+	["17th Battalion", "Medical"], // category
+	[[2, 4, 6, 8, 10], ["2", "4", "6", "8", "10"], 4] // option values, option labels, default index
+] call CBA_fnc_addSetting;
+
+
 diag_log text "[MILSIM] (settings) Custom CBA settings initialized";
 
 nil;