Wrapped up discharge form close #159

This commit is contained in:
2026-01-28 15:39:45 -05:00
parent c646254616
commit 22eaba6f90
8 changed files with 111 additions and 25 deletions

View File

@@ -5,12 +5,16 @@ import { Request, Response } from 'express';
import pool from '../db';
import { requireLogin, requireMemberState, requireRole } from '../middleware/auth';
import { getUserActiveLOA } from '../services/db/loaService';
import { getAllMembersLite, getMemberSettings, getMembersFull, getMembersLite, getUserData, getUserState, setUserSettings, getFilteredMembers } from '../services/db/memberService';
import { getAllMembersLite, getMemberSettings, getMembersFull, getMembersLite, getUserData, getUserState, setUserSettings, getFilteredMembers, setUserState } from '../services/db/memberService';
import { getUserRoles } from '../services/db/rolesService';
import { memberSettings, MemberState, myData } from '@app/shared/types/member';
import { Discharge } from '@app/shared/schemas/dischargeSchema';
import { Performance } from 'perf_hooks';
import { logger } from '../services/logging/logger';
import { memberCache } from './auth';
import { cancelLatestRank } from '../services/db/rankService';
import { cancelLatestUnit } from '../services/db/unitService';
//get all users
router.get('/', [requireLogin, requireMemberState(MemberState.Member)], async (req, res) => {
@@ -232,5 +236,32 @@ router.put('/:id/displayname', async (req, res) => {
return res.status(501);
});
//discharge member
router.post('/discharge', [requireLogin, requireMemberState(MemberState.Member), requireRole("17th Administrator")], async (req: Request, res: Response) => {
try {
var con = await pool.getConnection();
con.beginTransaction();
var data: Discharge = req.body;
setUserState(data.userID, MemberState.Retired, con);
cancelLatestRank(data.userID, con);
cancelLatestUnit(data.userID, con);
con.commit();
memberCache.Invalidate(data.userID);
res.sendStatus(200);
} catch (error) {
logger.error('app', 'Failed to discharge user', {
data: data,
caller: req.user.id,
error: error instanceof Error ? error.message : String(error),
stack: error instanceof Error ? error.stack : undefined,
})
} finally {
if (con)
con.release();
}
});
export const memberRouter = router;

View File

@@ -3,6 +3,7 @@ import pool from "../../db";
import { Member, MemberCardDetails, MemberLight, memberSettings, MemberState, PaginatedMembers } from '@app/shared/types/member'
import { logger } from "../logging/logger";
import { memberCache } from "../../routes/auth";
import * as mariadb from 'mariadb';
export async function getFilteredMembers(
page: number = 1,
@@ -98,12 +99,12 @@ export async function getUserData(userID: number): Promise<Member> {
return res[0] ?? null;
}
export async function setUserState(userID: number, state: MemberState) {
export async function setUserState(userID: number, state: MemberState, con: mariadb.Pool | mariadb.Connection = pool) {
try {
const sql = `UPDATE members
SET state = ?
WHERE id = ?;`;
return await pool.query(sql, [state, userID]);
return await con.query(sql, [state, userID]);
} catch (error) {
logger.error('app', 'Error setting user state', error);
} finally {

View File

@@ -3,6 +3,7 @@ import { PromotionDetails, PromotionSummary } from "@app/shared/types/rank"
import pool from "../../db";
import { PagedData } from "@app/shared/types/pagination";
import { toDate, toDateIgnoreZone, toDateTime } from "@app/shared/utils/time";
import * as mariadb from 'mariadb';
export async function getAllRanks() {
const rows = await pool.query(
@@ -105,4 +106,14 @@ export async function getPromotionsOnDay(day: Date): Promise<PromotionDetails[]>
let batchPromotion = await pool.query(sql, [dayString]) as PromotionDetails[];
return batchPromotion;
}
export async function cancelLatestRank(userID: number, con: mariadb.Pool | mariadb.Connection = pool): Promise<boolean> {
try {
let sql = `CALL sp_end_member_rank(?,NOW())`;
con.query(sql, [userID]);
return true;
} catch (error) {
throw error;
}
}

View File

@@ -0,0 +1,13 @@
import pool from "../../db";
import * as mariadb from 'mariadb';
export async function cancelLatestUnit(userID: number, con: mariadb.Pool | mariadb.Connection = pool): Promise<boolean> {
try {
let sql = `CALL sp_end_member_unit(?,NOW())`;
con.query(sql, [userID]);
return true;
} catch (error) {
throw error;
}
}